Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block & Blob Downloaders need manage the empty peerbook async #1317

Open
rodrigo-o opened this issue Oct 2, 2024 · 1 comment
Open

Block & Blob Downloaders need manage the empty peerbook async #1317

rodrigo-o opened this issue Oct 2, 2024 · 1 comment
Labels
bug Something isn't working P2 This is a nice to have. Improves usability of the app or the libraries, but it's not urgent.

Comments

@rodrigo-o
Copy link
Collaborator

Right now we have tech debt in how both block and blob downloaders manage the empty peerbook case.

Before #1314, the node hanged if no we run out peers due to #1308. After #1314 this raise, before it continually sleep making impossible for LibP2P to handle new peers. This needs to instead being delayed asynchronously to allow new peers to be part of the peerbook.

After #1314, this issue is less common due to a better penalization scheme and more time in the begining for peer discovery, but still possible if all initial peers aren't responding, luckily this isn't the case most of the times and it is an issue mostly at the start of the node where we have a small number of peers.

If this proves to be more common than anticipated it need to move from P2 to P1.

@rodrigo-o rodrigo-o added bug Something isn't working P2 This is a nice to have. Improves usability of the app or the libraries, but it's not urgent. labels Oct 2, 2024
@rodrigo-o
Copy link
Collaborator Author

This issue is related to #233

@rodrigo-o rodrigo-o changed the title Block & Blob Downloaders need to process retries and empty peerbook async Block & Blob Downloaders need manage the empty peerbook async Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 This is a nice to have. Improves usability of the app or the libraries, but it's not urgent.
Projects
Status: No status
Development

No branches or pull requests

1 participant