-
Notifications
You must be signed in to change notification settings - Fork 22
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge with https://github.com/tracecompass/tracecompass/tree/master/common/org.eclipse.tracecompass.common.core/annotations #10
Comments
These are only the ones which we didn't have at all yet; more next. https://github.com/tracecompass/tracecompass/tree/master/common/org.eclipse.tracecompass.common.core/annotations/java lastnpe#10
These are the ones I had to indivdually review and in many cases had to manually resolve merges; that's a PITA (and lead me to open lastnpe#16), thus I skipped merged java.lang.String, java.util.Collections and java.util.Map and kept my original ones, and did not merge with tracecompass' from https://github.com/tracecompass/tracecompass/tree/master/common/org.eclipse.tracecompass.common.core/annotations/java for lastnpe#10
These are only the ones which we didn't have at all yet; more next. https://github.com/tracecompass/tracecompass/tree/master/common/org.eclipse.tracecompass.common.core/annotations/java #10
These are the ones I had to indivdually review and in many cases had to manually resolve merges; that's a PITA (and lead me to open lastnpe#16), thus I skipped merged java.lang.String, java.util.Collections and java.util.Map and kept my original ones, and did not merge with tracecompass' from https://github.com/tracecompass/tracecompass/tree/master/common/org.eclipse.tracecompass.common.core/annotations/java for lastnpe#10
@kwin or anyone else interested (@maggu2810 ?) - terribly sorry for replying only now, but finally picking this project up... We would love to get these in. LICENSE should not be an issue, as both projects are EPL. I've made a start with the JDK ones in #15 and #17 (NB due to #16 I skipped merging java.lang.String, java.util.Collections and java.util.Map and kept my original ones, and did not merge with tracecompass' - review feedback on #17 would be welcome!). Would you like to add the other ones? Specifically tracecompass' Guava, Apache Commons would be interesting, useful and very welcome! BTW: As per README, you can become a committer on this project with x3 PRs! ;-) |
These are the ones I had to indivdually review and in many cases had to manually resolve merges; that's a PITA (and lead me to open #16), thus I skipped merged java.lang.String, java.util.Collections and java.util.Map and kept my original ones, and did not merge with tracecompass' from https://github.com/tracecompass/tracecompass/tree/master/common/org.eclipse.tracecompass.common.core/annotations/java for #10
Tracecompass has also maintained some external annotations for quite some libraries in the past. It seems right now much more extensive than this approach. Could you just merge all changes from https://github.com/tracecompass/tracecompass/tree/master/common/org.eclipse.tracecompass.common.core/annotations?
Not sure whether the license would allow that though.
The text was updated successfully, but these errors were encountered: