-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when calling LDClient.start
with large startWaitSeconds
on Apple Silicon
#392
Comments
@borodindr , thank you for reporting this and we appreciate the extra info you collected. We will take a look and release a fix when ready. |
Great! Thank you for the quick response. |
@borodindr , version 9.8.2 has been released and this issue should be fixed. I wasn't able to reproduce the issue myself since I don't have that specific device. Please let us know whether or not this resolves the issue for you. Thank you. |
@tanderson-ld version 9.8.2 was validated and the issue is fixed. Thank you! |
@borodindr , thank you for positively confirming! |
Describe the bug
When calling
LDClient.start
method withstartWaitSeconds
greater than 15, app crashes when it is trying to log the message. Happens only when a project running on Apple Silicon Mac with MacOS 14.4 or higher. Please don't be confused with Run Destination, it can be any.To reproduce
Required equipment:
Call the following anywhere on app launch:
Expected behavior
Log message is displayed and the app continue to work.
Logs
Screenshot of the crash:
Library version
LaunchDarkly 9.8.0 and 9.8.1.
XCode and Swift version
Platform the issue occurs on
All platforms if project ran from Xcode on MacOS 14.4 or higher with Apple Silicon
Additional context
When calling
os_log
inLDClient.start
method (line 792 in LDClient.swift file), the message has 3 parameters:%s
,%d
and%s
or string, decimal and string. But then arguments passed areString
,Double
andDouble
. On older MacOS versions, if argument type doesn't match, it will log(null)
but starting from MacOS 14.4 on Apple Silicon it produces an exception.Possible solution could be changing the third argument in the log message from
%s
to%d
like below:The text was updated successfully, but these errors were encountered: