-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next/Previous function in tool bar and assigned to hot keys don't work #542
Comments
Thanks for taking the time to report this @MartinL0815 The next/previous toolbar buttons are working for me.
I can reproduce the issue on VS2022 17.0.2 and 17.0.5, trying with different shortcut keys! |
Thanks @laurentkempe for your response! Strange the next/previous buttons in the tool bar work for you. First, the tool bar isn't available using the context menu of the tool bars. I need to open the customize dialog to make the tool bar visible. Since the hot keys don't work too, this ew would match. But if the tool bar buttons work for you, the situation would be not that easy. Again - the buttons in the floating tool bar related to a specific change work without problems! |
I am confused, could you add a screenshot of what you are taking about so that I am sure, thanks |
For sure, but earliest on Monday. |
Hi @laurentkempe, Here some screenshoots:
Does this helps a bit? I'd have expected, that the tool bar is accessible from the context menu and that the buttons on the tool bar are working, especially in a file with changes. |
Hi @MartinL0815 Screenshots always help 👍🏼 |
Good morning @laurentkempe, The margin works like expected. Clicking on a change pops-up the floating toolbar, which provides the expected functionality. |
Hey @MartinL0815 Yeah, I see it like you not working. I never considered using it like that. |
Sorry, I'm not sure if I understand. The hotkeys don't work, which is annoying working on the ViM mode (VsVim). So I tried to use the toolbar … with the mouse … unlikely. I don't understand where the confusion should come from. |
I can confirm this issue (also with VS 2019 and VS 2022):
I would love if the shortcuts would work. I'm also using VsVim and easily navigating to hunks makes a huge difference 😃 |
The confusion was on my side, I never thought of using the toolbar like you try to do! |
Thx for the confirmation @ybc37 It seems that one the latest updates of Visual Studio broke it. I would love to have more time that I could invest on it, but at the moment I cannot. |
I just found out about this extension and was hoping it could replace my external TortoiseGitMerge usage. I have noticed however that after opening "Show Difference" in the margin popup, I am able to use VS's Diff.NextDifference shortcuts. Although there doesn't seem to be a shortcut for Rollback. It'd be nice to have a shortcut to bring up that diff, as well as for rollback. Maybe the former already exists from VS, but I couldn't find it. Alternatively... there's probably a way to invoke an external diff tool with a hotkey somehow? |
It seems that Microsoft will finally provide the same capabilities directly in Visual Studio |
Thanks @Cleroth for the feedback
But that shortcut doesn't work anymore neither, it seems that something changed in some of the latest versions of Visual Studio which breaks all the shortcuts. |
That's nice. Unfortunately I had to uninstall the extension as the editor became super sluggish after erasing some blocks of code. Maybe there's some conflict with Resharper or something. Hopefully the VS version won't have such performance problems. After countless searches on how to use your own diff tool in VS, I just had to figure it out myself, which is actually really simple: Tools -> External Tools -> Add Not as good as having it in VS, but it works nicely for me, and can be possibly be adapted to any diff tool (likely the hard part is getting a file of the previous commit--luckily tortoisegit can do this). |
😢 Was the file big @Cleroth? I never realized such things myself, but maybe because I don't have huge files and yes, it is possible that there is a conflict with ReSharper. After removing it, did the problem disappear?
One of the features of GitDiffMargin was to let you double click on the margin to open the diff tool, if I remember it should open the diff tool configurer in your .gitconfig, but not sure anymore. I would need to look at the code. I have been using Rider and not much VS lately. The diff tool in Rider is fantastic, I even stopped using SemanticMerge to resolve conflicts and use the one in Rider. |
It's a 11k loc file, so I suppose relatively big. I did like Rider when I tried it. Performance is great. Unfortunately the lack of ability to combine .cpp and .h into one tab (through TabsStudio extension in VS) is a showstopper for me. (I've made a suggestion). That and the scrollbar doesn't work like VS's map mode. |
😵💫 Definitely!
I can imagine it comes from GitDiffMargin |
Confirmed under Visual Studio 2022 17.1.0 |
Hi, After trying a bit the new features about the the (in)line diff & Co. I'd like to get GitDiffMargin back, working, with keyboard shortcuts to step through and open a simple diff, not that complicated on provided by VS2022. If there is a chance to fix the problems, please do it! Best regards Martin |
Versions
What happened
After activating the extensions tool bar I can't use the next/previous buttons, they don't have an effect, don't move the caret.
Using the assigned hot keys don't work, too.
Clicking onto a change in the margin, the next/previous buttons in the floating tool bar work perfectly!
Steps to Reproduce
Steps to reproduce the behavior:
Expected behavior
I expected, that the changes in the current file are navigated by the tool bar buttons or the assigned hot keys.
The text was updated successfully, but these errors were encountered: