Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create actual authentication between the clients and server #1

Open
lawndoc opened this issue Jan 8, 2021 · 3 comments
Open

Create actual authentication between the clients and server #1

lawndoc opened this issue Jan 8, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@lawndoc
Copy link
Owner

lawndoc commented Jan 8, 2021

Currently, the server knows a connection is from a permitted client based on a port-specific "knock" phrase sent upon connection. Adding an actual authentication method to ensure only permitted clients can connect would be more secure.

@lawndoc
Copy link
Owner Author

lawndoc commented Jan 12, 2021

As of a5d3b47 clients submit an arbitrary connection key and are queued until they time out or can be bridged with their counterpart client that has a matching connection key. As of now, this process is unencrypted. Going to leave this issue open in order to encrypt the connection keys being sent.

@lawndoc
Copy link
Owner Author

lawndoc commented Feb 1, 2021

As of 5ae24b3 the connection key must start with the prefix "#!ConnectionKey_" without the quotes. This drops all client connections that don't contain a valid prefix in the connection key message. This process is currently still unencrypted.

@lawndoc lawndoc added the enhancement New feature or request label Jul 29, 2021
@lawndoc
Copy link
Owner Author

lawndoc commented Mar 31, 2022

Certificate-based authentication is probably a better way to go here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant