Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export extended Guard type #18

Open
lazarljubenovic opened this issue Oct 6, 2019 · 0 comments
Open

Export extended Guard type #18

lazarljubenovic opened this issue Oct 6, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@lazarljubenovic
Copy link
Owner

The lib currently exports Guard with only one generic argument: (x: any) => x is T, but I found that in code I often need (x: V) => x is T. Instead of exporting Guard<T>, we should export Guard<T, V = any>. This is not a breaking change since the second one is optional.
@lazarljubenovic lazarljubenovic added enhancement New feature or request good first issue Good for newcomers labels Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lazarljubenovic