feat: UI Improvements and Updates #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcrojano
added
good first issue
lcrojano
requested changes
Oct 21, 2024
There was a problem hiding this comment.
@itsharshitrwt Great contribution! 🎉
Before we proceed with accepting the PR, could you please pull the latest changes from the repository to ensure everything is up to date, especially in the ./husky folder? It looks like your current commit doesn’t include the latest updates from the main branch.
Thanks again for your hard work! 🚀
…into homepage-UI
|
Hi @lcrojano, Thanks for reviewing , I have pulled out latest changes. I hope this solves the issue if there is still some problem plz let me know :) If everything looks good, I would greatly appreciate it if you could take a moment to review and merge the PR 😄 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Update: Fixes #52
Hi @lcrojano ,
I am excited to share that I have made new UI changes to the Giphy website.
Previous:
New:
Additionally, I have improved the login and signup pages. Please note that I did not work on the "Add to Favorite" button, as that issue was assigned to someone else.
Suggestion: I recommend removing the website links from the GIF cards for a cleaner look.
If everything looks good, I would greatly appreciate it if you could take a moment to review and merge the PR.
Thank you!