-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Algebra/CategoryTheory): Add CommAlgebraCat #19299
base: master
Are you sure you want to change the base?
Conversation
PR summary 0aa334030bImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
@@ -238,3 +237,27 @@ instance AlgebraCat.forget_reflects_isos : (forget (AlgebraCat.{u} R)).ReflectsI | |||
{R} [CommRing R] {G : Type u} [Ring G] [Algebra R G] {H : AlgebraCat.{u} R} (f : G →ₐ[R] H) : | |||
AlgHom.comp (𝟙 H) f = f := | |||
Category.comp_id (AlgebraCat.ofHom f) | |||
|
|||
def isComm {R : Type u} [CommRing R] (A : AlgebraCat R) : Prop := ∀ x y : A, x * y = y * x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest you inline this
|
||
variable (R : Type u) [CommRing R] | ||
|
||
def CommAlgebraCat := FullSubcategory (fun (A : AlgebraCat R) => isComm A) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def CommAlgebraCat := FullSubcategory (fun (A : AlgebraCat R) => isComm A) | |
def CommAlgebraCat := FullSubcategory fun A : AlgebraCat R ↦ ∀ a b : A, a * b = b * a |
This PR/issue depends on: |
AlgebraCat
into a structure #19065