Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Algebra/CategoryTheory): Add CommAlgebraCat #19299

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

javierlcontreras
Copy link
Collaborator

@javierlcontreras javierlcontreras commented Nov 20, 2024

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Nov 20, 2024
@javierlcontreras javierlcontreras changed the title feat(Algebra/CategoryTheory/Category): Add CommAlgebraCat feat(Algebra/CategoryTheory): Add CommAlgebraCat Nov 20, 2024
@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Nov 20, 2024
Copy link

PR summary 0aa334030b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ CommAlgebra
+ CommAlgebraCat
+ coe_of
+ instance : Category (CommAlgebraCat R) := by unfold
+ instance : CoeSort (CommAlgebraCat R) (Type v) where coe A := A.obj.carrier
+ isComm
+ of

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@@ -238,3 +237,27 @@ instance AlgebraCat.forget_reflects_isos : (forget (AlgebraCat.{u} R)).ReflectsI
{R} [CommRing R] {G : Type u} [Ring G] [Algebra R G] {H : AlgebraCat.{u} R} (f : G →ₐ[R] H) :
AlgHom.comp (𝟙 H) f = f :=
Category.comp_id (AlgebraCat.ofHom f)

def isComm {R : Type u} [CommRing R] (A : AlgebraCat R) : Prop := ∀ x y : A, x * y = y * x
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest you inline this


variable (R : Type u) [CommRing R]

def CommAlgebraCat := FullSubcategory (fun (A : AlgebraCat R) => isComm A)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def CommAlgebraCat := FullSubcategory (fun (A : AlgebraCat R) => isComm A)
def CommAlgebraCat := FullSubcategory fun A : AlgebraCat R ↦ ∀ a b : A, a * b = b * a

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Nov 20, 2024
@javierlcontreras javierlcontreras added the WIP Work in progress label Nov 20, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Nov 25, 2024
@mathlib4-dependent-issues-bot
Copy link
Collaborator

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-algebra Algebra (groups, rings, fields, etc) WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants