Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename CompleteLattice.Independent/.SetIndependent to iSupIndep/sSupIndep #19409

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

YaelDillies
Copy link
Collaborator

These names are shorter, closer to SupIndep and clearer without their namespace.


Open in Gitpod

…pIndep`/`sSupIndep`

These names are shorter, closer to `SupIndep` and clearer without their namespace.
@YaelDillies YaelDillies added WIP Work in progress t-order Order theory labels Nov 23, 2024
Copy link

github-actions bot commented Nov 23, 2024

PR summary fb4e0f717a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Finset.SupIndep.iSupIndep_of_univ
+ IsInternal.iSupIndep
+ LinearIndependent.iSupIndep_span_singleton
+ Submodule.finite_ne_bot_of_iSupIndep
+ WellFounded.finite_ne_bot_of_iSupIndep
+ WellFoundedGT.finite_ne_bot_of_iSupIndep
+ WellFoundedGT.finite_of_iSupIndep
+ WellFoundedGT.finite_of_sSupIndep
+ WellFoundedLT.finite_ne_bot_of_iSupIndep
+ WellFoundedLT.finite_of_iSupIndep
+ WellFoundedLT.finite_of_sSupIndep
+ _root_.Set.PairwiseDisjoint.sSupIndep
+ exists_sSupIndep_isCompl_sSup_atoms
+ exists_sSupIndep_of_sSup_atoms_eq_top
+ iSupIndep
+ iSupIndep.comp
+ iSupIndep.comp'
+ iSupIndep.dfinsupp_lsum_injective
+ iSupIndep.dfinsupp_sumAddHom_injective
+ iSupIndep.disjoint_biSup
+ iSupIndep.fintypeNeBotOfFiniteDimensional
+ iSupIndep.injOn
+ iSupIndep.injective
+ iSupIndep.linearIndependent
+ iSupIndep.linear_independent'
+ iSupIndep.map_orderIso
+ iSupIndep.mono
+ iSupIndep.of_coe_Iic_comp
+ iSupIndep.pairwiseDisjoint
+ iSupIndep.sSupIndep_range
+ iSupIndep.subtype_ne_bot_le_finrank
+ iSupIndep.subtype_ne_bot_le_finrank_aux
+ iSupIndep.subtype_ne_bot_le_rank
+ iSupIndep.supIndep
+ iSupIndep.supIndep'
+ iSupIndep.sup_indep_univ
+ iSupIndep_def
+ iSupIndep_def'
+ iSupIndep_def''
+ iSupIndep_empty
+ iSupIndep_iff_dfinsupp_lsum_injective
+ iSupIndep_iff_dfinsupp_sumAddHom_injective
+ iSupIndep_iff_forall_dfinsupp
+ iSupIndep_iff_linearIndependent_of_ne_zero
+ iSupIndep_iff_pairwiseDisjoint
+ iSupIndep_iff_supIndep
+ iSupIndep_iff_supIndep_of_injOn
+ iSupIndep_iff_supIndep_univ
+ iSupIndep_map_orderIso_iff
+ iSupIndep_ne_bot_iff_independent
+ iSupIndep_of_dfinsupp_lsum_injective
+ iSupIndep_of_dfinsupp_sumAddHom_injective
+ iSupIndep_of_dfinsupp_sumAddHom_injective'
+ iSupIndep_pair
+ iSupIndep_pempty
+ iSupIndep_sUnion_of_directed
+ independent_iff_iSupIndep
+ isInternal_biSup_submodule_of_iSupIndep
+ sSupIndep
+ sSupIndep.disjoint_sSup
+ sSupIndep.mono
+ sSupIndep.pairwiseDisjoint
+ sSupIndep_empty
+ sSupIndep_iUnion_of_directed
+ sSupIndep_iff
+ sSupIndep_iff_finite
+ sSupIndep_iff_pairwiseDisjoint
+ sSupIndep_pair
+ sSupIndep_singleton
- CompleteLattice.Independent.fintypeNeBotOfFiniteDimensional
- CompleteLattice.Independent.linear_independent'
- CompleteLattice.Independent.subtype_ne_bot_le_finrank
- CompleteLattice.Independent.subtype_ne_bot_le_finrank_aux
- CompleteLattice.Independent.subtype_ne_bot_le_rank
- CompleteLattice.Independent.supIndep
- CompleteLattice.Independent.supIndep'
- CompleteLattice.Independent.sup_indep_univ
- CompleteLattice.independent_iff_supIndep
- CompleteLattice.independent_iff_supIndep_of_injOn
- CompleteLattice.independent_iff_supIndep_univ
- CompleteLattice.independent_sUnion_of_directed
- CompleteLattice.setIndependent_iUnion_of_directed
- CompleteLattice.setIndependent_iff_finite
- Finset.SupIndep.independent_of_univ
- Independent
- Independent.comp
- Independent.comp'
- Independent.dfinsupp_lsum_injective
- Independent.dfinsupp_sumAddHom_injective
- Independent.disjoint_biSup
- Independent.injOn
- Independent.injective
- Independent.linearIndependent
- Independent.map_orderIso
- Independent.mono
- Independent.pairwiseDisjoint
- Independent.setIndependent_range
- IsInternal.submodule_independent
- LinearIndependent.independent_span_singleton
- SetIndependent
- SetIndependent.disjoint_sSup
- SetIndependent.mono
- SetIndependent.pairwiseDisjoint
- Submodule.finite_ne_bot_of_independent
- WellFounded.finite_ne_bot_of_independent
- WellFoundedGT.finite_ne_bot_of_independent
- WellFoundedGT.finite_of_independent
- WellFoundedGT.finite_of_setIndependent
- WellFoundedLT.finite_ne_bot_of_independent
- WellFoundedLT.finite_of_independent
- WellFoundedLT.finite_of_setIndependent
- _root_.Set.PairwiseDisjoint.setIndependent
- exists_setIndependent_isCompl_sSup_atoms
- exists_setIndependent_of_sSup_atoms_eq_top
- independent_def
- independent_def'
- independent_def''
- independent_empty
- independent_iff_completeLattice_independent
- independent_iff_dfinsupp_lsum_injective
- independent_iff_dfinsupp_sumAddHom_injective
- independent_iff_forall_dfinsupp
- independent_iff_linearIndependent_of_ne_zero
- independent_iff_pairwiseDisjoint
- independent_map_orderIso_iff
- independent_ne_bot_iff_independent
- independent_of_dfinsupp_lsum_injective
- independent_of_dfinsupp_sumAddHom_injective
- independent_of_dfinsupp_sumAddHom_injective'
- independent_of_independent_coe_Iic_comp
- independent_pair
- independent_pempty
- isInternal_biSup_submodule_of_independent
- setIndependent_empty
- setIndependent_iff
- setIndependent_iff_pairwiseDisjoint
- setIndependent_pair
- setIndependent_singleton

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-order Order theory WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant