Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and document SampCert #10

Merged
merged 64 commits into from
May 29, 2024
Merged

Conversation

mjdemedeiros
Copy link
Collaborator

@mjdemedeiros mjdemedeiros commented May 21, 2024

Refactor and document SampCert up to Mathlib4 standards.

Progress

  • SLang.lean
  • Foundations/*
  • Samplers/*
  • DifferentialPrivacy/*
  • Extractor/*
  • Util/*
  • Extraction.lean

Extractor and CI work will be in a different PR

Tasks

  • Document contribution guidelines (including protected names for extraction which violate the matlib naming scheme)
  • remove explicit #lint docBlame (add linting to CI?)

@mjdemedeiros mjdemedeiros changed the title (WIP) Refactor and document Refactor and document SampCert May 28, 2024
@mjdemedeiros mjdemedeiros marked this pull request as ready for review May 28, 2024 19:55
@mjdemedeiros
Copy link
Collaborator Author

@jtristan Documentation is close to finished and should be merged before it goes too out of sync. Some functions (particularly in ZeroConcentrated/Postprocessing and Laplace/Properties) are not finished because I'm still digesting them.

I also wrote a CONTRIBUTING.md which briefly goes over the changes I made. If any of them are too controversial, I can change them back.

@jtristan jtristan merged commit 2748e48 into leanprover:main May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants