Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lake: Reservoir build cache #5486

Merged
merged 8 commits into from
Oct 1, 2024

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented Sep 27, 2024

Adds Reservoir as another possible source of build caches in addition to GitHub releases. If a GitHub release is not configured for a Reservoir dependency, it will attempt download a build cache from Reservoir. Like with GitHub releases, failure will not stop the build and instead issue a warning. Many of the Lake API calls related to these build caches were refactored and renamed, with the old names remaining around as deprecated aliases.

Build cache downloads (from Reservoir or GitHub) can now be disabled via the --no-cache CLI option or the LAKE_NO_CACHE environment variable. A disabled cache can be re-enable with the --try-cache CLI option.

@tydeu tydeu marked this pull request as draft September 27, 2024 03:13
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 27, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 27, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 27, 2024
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Sep 27, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 28, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 28, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 30, 2024
@tydeu tydeu marked this pull request as ready for review September 30, 2024 22:04
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 30, 2024
@tydeu tydeu added the release-ci Enable all CI checks for a PR, like is done for releases label Sep 30, 2024
@tydeu tydeu added this pull request to the merge queue Sep 30, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 1, 2024
Merged via the queue into leanprover:master with commit ffb4c5b Oct 1, 2024
26 checks passed
@tydeu tydeu deleted the lake/reservoir-build-cache branch October 1, 2024 00:41
kim-em added a commit that referenced this pull request Oct 4, 2024
kim-em added a commit that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants