-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ac_nf and test [ac_nf|ac_rfl] for BitVec #5524
Conversation
70386a1
to
9d60281
Compare
ac_nf is a counterpart to ac_rfl, which normalizes bitvector expressions with respect to associativity and commutativity. While there, we also add test coverage for ac_rfl and ac_nf for BitVec.
9d60281
to
8ecfda3
Compare
Mathlib CI status (docs):
|
Would you mind adding a small number of tests, just to exercise that it works for one or two other types besides BitVec? |
When searching for ac_rfl uses, I missed to add the test folder to my search path. There are indeed test cases already available. I now moved the BitVec test cases in the existing test file. This is now ready to go from my side. |
ac_nf is a counterpart to ac_rfl, which normalizes bitvector expressions with respect to associativity and commutativity.
While there, also add test coverage for ac_rfl and ac_nf for BitVec, complementing the existing test coverage.