Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ac_nf and test [ac_nf|ac_rfl] for BitVec #5524

Merged
merged 7 commits into from
Oct 1, 2024

Conversation

tobiasgrosser
Copy link
Contributor

@tobiasgrosser tobiasgrosser commented Sep 29, 2024

ac_nf is a counterpart to ac_rfl, which normalizes bitvector expressions with respect to associativity and commutativity.

While there, also add test coverage for ac_rfl and ac_nf for BitVec, complementing the existing test coverage.

ac_nf is a counterpart to ac_rfl, which normalizes bitvector expressions
with respect to associativity and commutativity.

While there, we also add test coverage for ac_rfl and ac_nf for BitVec.
@tobiasgrosser tobiasgrosser marked this pull request as ready for review September 29, 2024 20:27
@tobiasgrosser tobiasgrosser changed the title feat: add ac_nf and add test cases for BitVec feat: add ac_nf and test [ac_nf|ac_rfl] for BitVec Sep 29, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 29, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Sep 29, 2024

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 4cd4bcc9be195f0b0a6a6a9e47522a41e044eabc --onto 9460f79d28d3a72d7484766b5f2c83362e91dd5b. (2024-09-29 20:44:37)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 4cd4bcc9be195f0b0a6a6a9e47522a41e044eabc --onto 994cfa4c74a066df050ca889da912e71fa70cd85. (2024-09-30 04:47:42)

@kim-em
Copy link
Collaborator

kim-em commented Sep 30, 2024

Would you mind adding a small number of tests, just to exercise that it works for one or two other types besides BitVec? Int would be fine.

@tobiasgrosser
Copy link
Contributor Author

tobiasgrosser commented Sep 30, 2024

Would you mind adding a small number of tests, just to exercise that it works for one or two other types besides BitVec? Int would be fine.

When searching for ac_rfl uses, I missed to add the test folder to my search path. There are indeed test cases already available. I now moved the BitVec test cases in the existing test file. This is now ready to go from my side.

@kim-em kim-em added this pull request to the merge queue Oct 1, 2024
Merged via the queue into leanprover:master with commit 37baa89 Oct 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants