chore: rename Array.flatten to join, and upstream lemmas #5535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the motivation for this? It's a closer match to Haskell, but I think most programmers would have an easy time guessing "flatten" and a difficult time guessing "join" for this operation. |
|
I second David's concern, |
|
If everyone is happy with renaming |
|
Replaced by #5551 |
auto-merge was automatically disabled
October 2, 2024 00:47
Pull request was closed
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
Just the upstreaming part of #5535 while we wait on a naming decision.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.