fix: rm new shared libs before build for Windows #5541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kha As this touches the build code, a 👍 from you might be helpful. |
tydeu
added
the
release-ci
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 30, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Sep 30, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 30, 2024
leanprover-community-bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tydeu
force-pushed
the
rm-new-libs-prebuild
branch
from
d13c79d
to
8750b5c
Compare
tydeu
added
the
needs-update-stage0
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 2, 2024
(late 👍) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, shared libraries must be removed before linking. Otherwise, linking can fail with "Permission denied" when the libraries are in use. This ensures such removal is done for the new
libLake_shared.dlland both parts oflibleanshared.