Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KCard: Update spaces to the latest designs #704

Closed
2 tasks
MisRob opened this issue Jul 27, 2024 · 1 comment
Closed
2 tasks

KCard: Update spaces to the latest designs #704

MisRob opened this issue Jul 27, 2024 · 1 comment
Assignees
Labels
category: library Shared code library Component: KCard P2 - normal Priority: Nice to have

Comments

@MisRob
Copy link
Member

MisRob commented Jul 27, 2024

Summary

Update spaces between card's content and its border to the latest designs.

References

This need is motivated by new additions to the cards family in Kolibri, such as

Current behavior

When developing the first version of KCard, we worked with WIP designs and frequently used 12px for paddings and margins, for example here

Screenshot from 2024-07-27 14-27-19

Expected behavior

Now when we're building first few production cards, let's align KCard to the final designs. It seems that most frequently, there's 24px top/right/bottom/left space between content and card's border, so let's use this value for default KCard behavior.

Screenshot from 2024-07-27 14-33-59

Out of scope

Rarely, there are exceptions, such as here 16px space at the bottom.

Screenshot from 2024-07-27 14-37-38

There's no need to be worried about it in the scope of this issue. This task is only about using the most common value as default. We can clarify deviations with the design team as we're building the productions cards and either update designs or add some options to configure KCard from outside.

Acceptance criteria

  • All layouts are updated (for consistency)
  • No regressions in any of the layouts
@MisRob
Copy link
Member Author

MisRob commented Aug 1, 2024

Closed by #709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: library Shared code library Component: KCard P2 - normal Priority: Nice to have
Projects
None yet
Development

No branches or pull requests

2 participants