Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffusion Step clarification #3

Open
som1990 opened this issue Apr 10, 2019 · 0 comments
Open

Diffusion Step clarification #3

som1990 opened this issue Apr 10, 2019 · 0 comments

Comments

@som1990
Copy link

som1990 commented Apr 10, 2019

Hey,
Just curious if your diffusion step is incomplete.
I'm doing a comparison of your method with another method so implementing your code and I noticed this.

In equation 18 of the paper , there are two diffusion steps ( angular and directional diffusion). In your implementation you do have a second order finite difference implemented with a incomplete gamma equation(compared to the paper) but no mention of the delta(directional diffusion) part of the equation. You also seem to be missing the groupspeed applied to advected amplitude.
I ran through your code several times and don't see these implemented. Am I missing something?

Please let me know. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant