Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternative GH auth: GH app #365

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Add alternative GH auth: GH app #365

merged 2 commits into from
Nov 23, 2024

Conversation

ledoyen
Copy link
Member

@ledoyen ledoyen commented Nov 17, 2024

⚠️ TODO

GitHub action check

Copy link

github-actions bot commented Nov 17, 2024

Test Results

31 tests   31 ✅  33s ⏱️
14 suites   0 💤
14 files     0 ❌

Results for commit 2b28472.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 31.91489% with 64 lines in your changes missing coverage. Please review.

Project coverage is 33.42%. Comparing base (cb78861) to head (2b28472).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...it/thirdparty/github/GitHubAuthenticationHolder.kt 20.54% 57 Missing and 1 partial ⚠️
...jo/korekto/toolkit/thirdparty/git/GitRepository.kt 50.00% 3 Missing ⚠️
...n/com/github/lernejo/korekto/toolkit/GradingJob.kt 0.00% 1 Missing ⚠️
...ejo/korekto/toolkit/launcher/GradingJobLauncher.kt 0.00% 1 Missing ⚠️
...o/korekto/toolkit/thirdparty/git/ExerciseCloner.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #365      +/-   ##
============================================
- Coverage     33.95%   33.42%   -0.54%     
+ Complexity      141      140       -1     
============================================
  Files            54       55       +1     
  Lines          2082     2124      +42     
  Branches        254      252       -2     
============================================
+ Hits            707      710       +3     
- Misses         1295     1338      +43     
+ Partials         80       76       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ledoyen ledoyen force-pushed the feature/github_app_auth branch 2 times, most recently from 52180d4 to b6d1855 Compare November 23, 2024 18:54
@ledoyen ledoyen force-pushed the feature/github_app_auth branch from a354377 to 2b28472 Compare November 23, 2024 19:31
@ledoyen ledoyen enabled auto-merge (rebase) November 23, 2024 19:31
@ledoyen ledoyen merged commit 55a7208 into main Nov 23, 2024
4 of 6 checks passed
@ledoyen ledoyen deleted the feature/github_app_auth branch November 23, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant