Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression of a resolution #43

Open
everzeni opened this issue Aug 29, 2017 · 7 comments
Open

Expression of a resolution #43

everzeni opened this issue Aug 29, 2017 · 7 comments
Labels

Comments

@everzeni
Copy link
Collaborator

I'm doubting about this example:

The high spatial resolution of the images (40 mas per pixel, corresponding to ≥ 100 km per pixel) resolve the inner coma, and allow investigations of the dust grain expansion velocities.

I would tend to annotate the ANGLE unit and the LENGTH unit, independantly from the "per pixel" part, (because mas/pixel or km/pixel doesn't seem to be a known unit, but I'm not sure at all about that):

- <measure type="value"><num>40</num> <measure type="ANGLE" unit="mas">mas</measure>
</measure> per pixel

- ≥ <measure type="interval"><num atLeast="100">100</num> <measure type="LENGTH" 
unit="km">km</measure></measure> per pixel

If we were to annotate mas/pixel and km/pixel as plain units, what would be their type? (create a RESOLUTION type? UNKNOWN ? DENSITY ?)

What do you think?

@lfoppiano
Copy link
Owner

Good question Emilia..

Your approach seems the most conservative and looks good.
I would mark this part and come back to it later. I'm wondering what a pixel is... I actually would tend to annotate pixel as part of the unit and add the type resolution, although this unit looks pretty tricky as doesn't seems to have a scientific value / correspondence in inches/mm.

@kermitt2
Copy link
Collaborator

I would annotate all the units, even the "creative" ones. It's the "generative" aspect of a scientific nomenclature.... so annotate pixel as part of the unit - and I would do it now because it would take a lot of time to come back to cases like that diluted in the training data (from my own experience :( ).

In image technical stuff, I have the feeling that pixel is quite common, for instance bits per pixel (bpp) or pixels per inch (ppi). As Luca says, I think they all correspond to density measures.

@everzeni
Copy link
Collaborator Author

So I annotate:

- <measure type="value"><num>40</num> <measure type="DENSITY" unit="mas/pixel">
mas per pixel </measure></measure> 

- ≥ <measure type="interval"><num atLeast="100">100</num> <measure type="DENSITY" 
unit="km/pixel">km per pixel</measure></measure>

?

@kermitt2
Copy link
Collaborator

Yes!
But I think I would use uniform notation "mas.pixel^-1" "km.pixel^-1" instead of the /
@lfoppiano what do you think ?

@lfoppiano
Copy link
Owner

@kermitt2 I agree with uniform the annotation of the unit

Regarding the type, while discussing with @everzeni we've found that the spacial/angular resolution seems a more appropriate type for this kind of measurement involving pixels. What do you think to have such measures annotated with type SPACIAL_RESOLUTION or we could group all the resolutions with a single type: RESOLUTION.

@everzeni
Copy link
Collaborator Author

So I annotated:

The high spatial resolution of the images (<measure type="value"><num>40</num> <measure 
type="RESOLUTION" unit="mas.pixel^-1">mas per pixel</measure></measure>, corresponding to ≥ 
<measure type="interval"><num atLeast="100">100</num> <measure type="RESOLUTION" 
unit="km.pixel^-1">km per pixel</measure></measure>)

@kermitt2 please confirm that we can add the type RESOLUTION

@lfoppiano
Copy link
Owner

Since SPACIAL RESOLUTION and ANGULAR RESOLUTION are the same, yes, we add the new type RESOLUTION

@everzeni everzeni added task and removed question labels Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants