Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme 'running tests' example fails #14

Open
Sideboard opened this issue Sep 29, 2021 · 5 comments
Open

Readme 'running tests' example fails #14

Sideboard opened this issue Sep 29, 2021 · 5 comments

Comments

@Sideboard
Copy link

The example from the readme does not work. Did the arguments change?

$ mkdir -p example_run_dir/CSiGe/run_dir
$ cd example_run_dir/CSiGe/run_dir
$ ../../../scripts/run-model-test.py -s CSiGe Tersoff bulk_Si_diamond
usage: run-model-test.py [-h] [--system_label SYSTEM_LABEL] [--force]
                         [--base_model BASE_MODEL] [--no_redirect_io]
                         [--no_append_log]
                         model test
run-model-test.py: error: unrecognized arguments: -s bulk_Si_diamond

Removing the -s option creates a text file with further errors concerning paths:

$ ../../../scripts/run-model-test.py Tersoff bulk_Si_diamond
share_dir /home/u2073032/nomad/code/testing-framework/scripts/../share
$ cat model-Tersoff-test-bulk_Si_diamond.txt

###### START RUN Wed Sep 29 14:13:52 2021 ######
Model Tersoff, Test bulk_Si_diamond
Test run at 2021-09-29 14:13

model file: ../../models/Tersoff/model.py
============================================================
Traceback (most recent call last):
  File "../../../scripts/run-model-test.py", line 118, in <module>
    sys.stdout.write(open(model_file).read())
FileNotFoundError: [Errno 2] No such file or directory: '../../models/Tersoff/model.py'
@bernstei
Copy link
Contributor

Yes, --test_set / -s became --system_label / -l, but the docs were not updated.

@jameskermode
Copy link
Member

Looking at the demo notebook I think it should be -l Si rather than -s Si. If that works we should fix the README.

@jameskermode
Copy link
Member

I updated the README

@Sideboard
Copy link
Author

Yes, -l works. The second problem still occurs for me. Does it work for you?

@jameskermode
Copy link
Member

Didn't check. Working on reviving the Binder, and then at least you'll have a working example to compare with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants