Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Integrate unit and spec benchmarking in js-libp2p CI #2118

Open
2 of 3 tasks
SgtPooki opened this issue Oct 3, 2023 · 4 comments
Open
2 of 3 tasks

perf: Integrate unit and spec benchmarking in js-libp2p CI #2118

SgtPooki opened this issue Oct 3, 2023 · 4 comments
Labels
effort/days Estimated to take multiple days, but less than a week help wanted Seeking public contribution on this issue topic/perf Performance

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Oct 3, 2023

discussed in https://pl-strflt.notion.site/js-libp2p-perf-benchmarking-f7c42f96cbd44799a321347f6c15c8d4?pvs=4

Goals

Tasks

  1. P1 kind/test
  2. kind/discussion need/analysis
@SgtPooki SgtPooki added the need/triage Needs initial labeling and prioritization label Oct 3, 2023
@SgtPooki SgtPooki changed the title chore: chore: unit & spec performance benchmarking Oct 3, 2023
@SgtPooki
Copy link
Member Author

SgtPooki commented Oct 3, 2023

@maschad there was an action item for you in the Notion doc to create an issue for something (that wasn't captured well). pinging you here to request cleanup/refining of this issue (or close and point to issue you may have created?)

@maschad maschad changed the title chore: unit & spec performance benchmarking perf: unit & spec performance benchmarking Oct 3, 2023
@maschad maschad changed the title perf: unit & spec performance benchmarking perf: Integrated unit and spec benchmarking in js-libp2p CI Oct 3, 2023
@maschad
Copy link
Member

maschad commented Oct 3, 2023

Thanks for creating this @SgtPooki This issue was created libp2p/test-plans#307 in test plans, I've also updated the description.

@maschad maschad added P1 High: Likely tackled by core team if no one steps up topic/perf Performance and removed need/triage Needs initial labeling and prioritization labels Oct 3, 2023
@maschad maschad self-assigned this Oct 3, 2023
@maschad maschad changed the title perf: Integrated unit and spec benchmarking in js-libp2p CI perf: Integrate unit and spec benchmarking in js-libp2p CI Oct 3, 2023
@maschad maschad removed their assignment May 2, 2024
@dhuseby
Copy link
Contributor

dhuseby commented May 7, 2024

Would need a place to store the benchmark data. Would be nice to have this on every CI pass so that we could see trends in performance. Requires a self-hosted runner since it would be part of the CI pipe and this is a performance metrics test.

@dhuseby
Copy link
Contributor

dhuseby commented May 7, 2024

@achingbrain suggested adding this to the existing self-hosting runner currently doing transport interrupt tests.

@achingbrain achingbrain added help wanted Seeking public contribution on this issue effort/days Estimated to take multiple days, but less than a week and removed P1 High: Likely tackled by core team if no one steps up labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/days Estimated to take multiple days, but less than a week help wanted Seeking public contribution on this issue topic/perf Performance
Projects
Status: 🧱Blocked
Development

No branches or pull requests

4 participants