-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.53
release
#4545
Comments
Changelog: I added #4672 which attempts to fix a quite drastic bug in the new |
@mxinden @umgefahren What should we do about the API changes to Can we somehow get the best of both worlds and say with high certainty that the API designed in #4568 is what we need, merge that as part of |
We could, but we'd have to do all the necessary refactors over all transports. |
I am in favor of that too. It will mean that likely, AutoNATv2 will have to wait for the next breaking release though. There are a couple more PRs open that I'd like to merge but otherwise it is pretty much ready to go out. The v0.52 release dragged on for about a month which I really want to avoid this time. |
I'm fine with that, depending on when the next breaking release is scheduled. |
I suggest we don't block |
@thomaseizinger once this goes out should I update #4371 to ship as a non-breaking change? Or should we delay a day or two while I get it cleaned up to include in this release? |
Best to coordinate with @StemCll what their plans are on working on it. I don't see any reason to block the release on it. I am writing the release notes today and then we should be good to go :) |
I've drafted some release notes here: https://hackmd.io/@thomaseizinger/SkA-nMG7a/edit Feedback is welcome, feel free to just edit it :) @mxinden Once #4794 is merged, feel free to cut a release with the above notes. |
Very well written. Lots of attention to details. Made a couple of minor changes. Thank you @thomaseizinger. This will be an entertaining read for users.
Will do 🎉 |
Couple of learnings from the making the release post (I'll send a docs PR later):
|
Tracking issue for the upcoming
v0.53
release to make sure we don't forget anything.PRs to include in final patch release
Config::set_connection_keep_alive
#4029KeepAlive::Until
#4656NodeStatus
#4645Tasks
#[non_exhaustive]
to key enums #4581The text was updated successfully, but these errors were encountered: