Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.53 release #4545

Closed
13 of 14 tasks
thomaseizinger opened this issue Sep 24, 2023 · 11 comments · Fixed by #4796
Closed
13 of 14 tasks

v0.53 release #4545

thomaseizinger opened this issue Sep 24, 2023 · 11 comments · Fixed by #4796
Labels
tracking-issue Issues which are the entry point to bigger projects.
Milestone

Comments

@thomaseizinger
Copy link
Contributor

thomaseizinger commented Sep 24, 2023

Tracking issue for the upcoming v0.53 release to make sure we don't forget anything.

PRs to include in final patch release

  1. send-it
  2. send-it
  3. send-it
  4. internal-change
  5. send-it
  6. send-it
  7. internal-change
  8. internal-change

Tasks

  1. internal-change
    dhuseby
@thomaseizinger thomaseizinger added the tracking-issue Issues which are the entry point to bigger projects. label Sep 24, 2023
@thomaseizinger thomaseizinger added this to the v0.53.0 milestone Sep 24, 2023
@thomaseizinger
Copy link
Contributor Author

Changelog: I added #4672 which attempts to fix a quite drastic bug in the new SwarmBuilder.

@thomaseizinger
Copy link
Contributor Author

thomaseizinger commented Oct 27, 2023

@mxinden @umgefahren What should we do about the API changes to Transport in regards to this release? I don't really want to block this release on all of AutoNATv2 being implemented but we also said to not merge the changes until we have validated the API.

Can we somehow get the best of both worlds and say with high certainty that the API designed in #4568 is what we need, merge that as part of v0.53 and ship AutoNATv2 as a patch-release then?

@umgefahren
Copy link
Contributor

We could, but we'd have to do all the necessary refactors over all transports.
However I suggested first testing if the Transport trait updates work with the AutoNATv2 implementation. I would leave the decision to @mxinden and @thomaseizinger

@thomaseizinger
Copy link
Contributor Author

However I suggested first testing if the Transport trait updates work with the AutoNATv2 implementation. I would leave the decision to @mxinden and @thomaseizinger

I am in favor of that too. It will mean that likely, AutoNATv2 will have to wait for the next breaking release though. There are a couple more PRs open that I'd like to merge but otherwise it is pretty much ready to go out.

The v0.52 release dragged on for about a month which I really want to avoid this time.

@umgefahren
Copy link
Contributor

I'm fine with that, depending on when the next breaking release is scheduled.

@mxinden
Copy link
Member

mxinden commented Oct 29, 2023

I suggest we don't block v0.53 on AutoNATv2. I suggest we aim for AutoNATv2 and related changes in v0.54.

@dhuseby
Copy link
Contributor

dhuseby commented Nov 2, 2023

@thomaseizinger once this goes out should I update #4371 to ship as a non-breaking change? Or should we delay a day or two while I get it cleaned up to include in this release?

@thomaseizinger
Copy link
Contributor Author

@thomaseizinger once this goes out should I update #4371 to ship as a non-breaking change? Or should we delay a day or two while I get it cleaned up to include in this release?

Best to coordinate with @StemCll what their plans are on working on it.

I don't see any reason to block the release on it. I am writing the release notes today and then we should be good to go :)

@thomaseizinger
Copy link
Contributor Author

I've drafted some release notes here: https://hackmd.io/@thomaseizinger/SkA-nMG7a/edit

Feedback is welcome, feel free to just edit it :)

@mxinden Once #4794 is merged, feel free to cut a release with the above notes.

@mxinden
Copy link
Member

mxinden commented Nov 4, 2023

I've drafted some release notes here: https://hackmd.io/@thomaseizinger/SkA-nMG7a/edit

Very well written. Lots of attention to details. Made a couple of minor changes. Thank you @thomaseizinger. This will be an entertaining read for users.

@mxinden Once #4794 is merged, feel free to cut a release with the above notes.

Will do 🎉

@mxinden mxinden mentioned this issue Nov 5, 2023
4 tasks
@mergify mergify bot closed this as completed in #4796 Nov 5, 2023
@thomaseizinger
Copy link
Contributor Author

Couple of learnings from the making the release post (I'll send a docs PR later):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracking-issue Issues which are the entry point to bigger projects.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants