Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_html does not call forms or _extract_forms #218

Open
spazm opened this issue May 8, 2017 · 1 comment
Open

update_html does not call forms or _extract_forms #218

spazm opened this issue May 8, 2017 · 1 comment
Assignees

Comments

@spazm
Copy link
Contributor

spazm commented May 8, 2017

lee...@gmail.com reported on Nov 23, 2012

What steps will reproduce the problem?
1. Add a form to (an empty) document using the update_html method
2. Call the forms method
3. Find no forms

What is the expected output? What do you see instead?
I expected to see a form 

What version of the product are you using? On what operating system?
Latest

Please provide any additional information below.
Could just put a call at the end of update_html to _extract_forms, and allow updated documents to continue to function as one might expect

Details

Imported from Google Code issue 241 via archive

  • Type: Defect
  • Date: Nov 23, 2012
  • Reporter: lee...@gmail.com
  • Owner: ----
  • Priority: Medium
  • Status: New
@simbabque simbabque self-assigned this Jul 29, 2022
simbabque added a commit that referenced this issue Jul 29, 2022
This commit also removes an old SKIP check that we don't need any more
because we now depend on HTML::TreeBuilder.
@simbabque
Copy link
Contributor

This has already been fixed. I'm adding tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants