-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean LinboxError/LinBoxError #187
Labels
Comments
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Two different general errors exist within linbox and they are both used:
linbox/util/debug.h
:class LinBoxError
(which inherits fromNotImplementedYet
)linbox/util/error.h
:class LinboxError
(declined to things likeLinboxMathInconsistentSystem
)Which one to keep?
About errors' use cases, it looks like we need:
LinBoxError
(or some generic error)PreconditionFailed
NotImplementedYet
InvalidInput
(for readers)InconsistentSystem
but others are left unused (
LinboxMathDivZero
,LinBoxFailure
, ...)Moreover, while cleaning, in
debug.h
it looks like there is a concept ofException
(BadInputException
,LINBOX_RAISE_EXCEPTION
etc.) that is never used.The text was updated successfully, but these errors were encountered: