Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change field type of url field #400

Open
tester22 opened this issue Jul 14, 2022 · 1 comment
Open

Change field type of url field #400

tester22 opened this issue Jul 14, 2022 · 1 comment

Comments

@tester22
Copy link

tester22 commented Jul 14, 2022

The field for the url (blackbox exporter probe) is of type URLField. This prevents the blackboxexporter to be used for tcp, ssh and smtp probes.

url = models.URLField(max_length=256)

Changing it to CharField would introduce less validations but the fuctionality would be more flexible.

@kfdm
Copy link
Collaborator

kfdm commented Nov 8, 2022

I think internally we're only using blackbox exporter as an http check, hence using URLField, but you're correct that blackbox_exporter supports other kinds of checks as well. It's something that might be worth fixing, but we would also probably want to clean up the labels suggesting that it's an http only check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants