Remove dependency on zookeeper-candidate #2360
Assignees
Comments
|
related: twitter-archive/commons#485 |
adleong
pushed a commit
that referenced
this issue
Jan 7, 2020
The artifact for com.twitter.common.zookeeper" % "candidate" % "0.0.84" on maven.twttr.com is not present anymore. Therefore we need to cpy the bits that we use from it and have it in our sourcecode. Fixes #2360 Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The artifact for
com.twitter.common.zookeeper" % "candidate" % "0.0.84"on maven.twttr.com has been removed and the Linkerd build is broken as a result. Our zk-leader-namer depends on this library to determine the leader of a zookeeper group.We can remove this dependency and restore our build by copying the files and code we need from this package directly into the Linkerd code base. The relevant files we depend on are https://github.com/twitter/commons/blob/master/src/java/com/twitter/common/zookeeper/Candidate.java and related files.
Note that Finagle has done a similar thing to remove their dependency on zookeeper-candidate. Some (but not all) of the files that we need from zookeeper-candidate have been copied to https://github.com/twitter/finagle/tree/develop/finagle-serversets/src/main/java/com/twitter/finagle/common/zookeeper
The text was updated successfully, but these errors were encountered: