Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize or use mocking in tests #3

Open
cmungall opened this issue Mar 11, 2022 · 3 comments
Open

Dockerize or use mocking in tests #3

cmungall opened this issue Mar 11, 2022 · 3 comments

Comments

@cmungall
Copy link
Member

Currently tests fail in actions, they depend on solr in docker, figure out how best to orchestrate w GH actions

@sierra-moxon
Copy link
Member

@kevinschaper - do you have any additional insights here? Are you using linkml-solr and solr in a containerized implementation?

@kevinschaper
Copy link
Contributor

I haven't looked at how it fails, but the extra context is that the lsolr command will start up Solr in docker for you, but in a GitHub action I'm fairly sure you can't just execute a docker run

I think running the Solr container explicitly as a part of the action might work, and setup the tests around an assumption that Solr is already there

Testing the lsolr start command itself should probably just use mocking to make sure it's calling the right sh command

@gaurav
Copy link

gaurav commented Mar 29, 2023

Translator SRI uses a containerized Solr instance to run Name Lookup: we prepare a Solr backup containing all the synonym information, and then the container downloads and restores that backup when initializing. I don't know if a similar strategy would work for you, but feel free to steal some ideas from there or to ask Yaphet or me any questions you have!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants