Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

func UpdateUser() saves not hashed password to DB #5

Open
ilyaikik opened this issue Oct 31, 2019 · 0 comments
Open

func UpdateUser() saves not hashed password to DB #5

ilyaikik opened this issue Oct 31, 2019 · 0 comments

Comments

@ilyaikik
Copy link

In user.go
function UpdateUser
saves not hashed password to DB.
So, it should look something like this:

func UpdateUser(w http.ResponseWriter, r *http.Request) {
	user := &models.User{}
	params := mux.Vars(r)
	var id = params["id"]
	db.First(&user, id)
	json.NewDecoder(r.Body).Decode(user)

	pass, err := bcrypt.GenerateFromPassword([]byte(user.Password), bcrypt.DefaultCost)
	if err != nil {
		fmt.Println(err)
		err := ErrorResponse{
			Err: "Password Encryption  failed",
		}
		json.NewEncoder(w).Encode(err)
	}
	user.Password = string(pass)

	db.Save(&user)
	json.NewEncoder(w).Encode(&user)
}

Sorry for posting like this) Sometime I will have a time to post some PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant