Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erroneous reporting of failing connection #1041

Open
RSirois opened this issue Jan 26, 2024 · 11 comments
Open

Erroneous reporting of failing connection #1041

RSirois opened this issue Jan 26, 2024 · 11 comments
Labels

Comments

@RSirois
Copy link

RSirois commented Jan 26, 2024

Desklet version/Build date

1.5

Cinnamon version

Cinnamon 6.0.4

Distribution

LMDE 6 (faye) x86_64

Graphics hardware and driver used

AMD ATI Radeon RX 6400/6500 XT/6500M, default debian driver

Desklet name and maintainer

hostcheck@schorschii @schorschii

What happened?

The desklet is set to report connectivity to the router. The computer and router are 8 feet from each other. Hostcheck reports a connectivity issue repeatedly spaced several minutes apart and the outage is reported for about half a minute. it is set to check every 15 seconds. I have a continuous ping running, and I am using the computer. there is no connectivity issue. I had to disable the desklet.

Other information

neofetch
.-::---.. randy@eagle .:++++ooooosssoo:. ----------- .+o++::. .:oos+. OS: LMDE 6 (faye) x86_64
:oo:. -+oo: Host: X570S AERO G -CF +o/ .::::::-. .++- Kernel: 6.1.0-17-amd64
/s/ .yyyyyyyyyyo: +o- Uptime: 14 hours, 53 mins
so .ss ohyo :s-: Packages: 2404 (dpkg), 17 (flatpak)
s/ .ss h m myy/ /s`` Shell: bash 5.2.15 s: oo s m Myy+-o: Resolution: 5120x2880
oo :+sdoohyoydyso/. DE: Cinnamon 6.0.4 :o. .:////////++: WM: Mutter (Muffin) /++ -:::::- WM Theme: Mint-Y-Dark-Blue (Mint-Y)
++- Theme: Adwaita [GTK2/3] /+- Icons: Adwaita [GTK2/3]
.+/. Terminal: gnome-terminal
.:+-. CPU: AMD Ryzen 7 3800X (16) @ 3.900GHz
`--.`` GPU: AMD ATI Radeon RX 6400/6500 XT/6500M
Memory: 11351MiB / 64193MiB

@RSirois RSirois added the bug label Jan 26, 2024
@schorschii
Copy link
Contributor

Please concretize the "connectivity issue". What exactly does the desktop notification show? (Please enable the desktop notification for debugging, if you don't have it already.)

@RSirois
Copy link
Author

RSirois commented Jan 27, 2024 via email

@schorschii
Copy link
Contributor

schorschii commented Jan 27, 2024

So the exact output of this ping command on the desktop notification would be interesting... As soon as this output reports a packet loss greater than 0%, the desklet says "CRIT". So I think you actually have short network dropouts since I'm not able to reproduce this behavior. It's not that unusual when using WiFi.

Have you looked what statistics your separate ping command in the terminal reports after exiting it with Ctrl+C? Surely it reports a small packet loss >0% too.

@RSirois
Copy link
Author

RSirois commented Jan 29, 2024 via email

@schorschii
Copy link
Contributor

then it is useless

Wow, what kind words. So how would you design a ping check to be "useful"??

@RSirois
Copy link
Author

RSirois commented Jan 31, 2024 via email

@schorschii
Copy link
Contributor

I don't know @RSirois . As you see in the notification output, it internally uses the normal ping command line. Since you are the only one reporting this issue and there is no idea how to improve it, I think this issue should be closed.

@RSirois
Copy link
Author

RSirois commented Feb 14, 2024 via email

@zhurin
Copy link

zhurin commented Aug 14, 2024

Since you are the only one reporting this issue and there is no idea how to improve it, I think this issue should be closed.

Hi @schorschii he's not alone. After encountering the same false positives running multiple versions of Linux Mint and double-checking via CLI ping, the multiple hosts of ping.pe, and external server monitoring that the server(s) are reachable, I came here and found this issue.

The similarity in my case is that my laptop is also connected via Wi-Fi. After reading the comments thus far, I took a closer look at recent false positive notifications and they all report a ping time exceeding 1000 ms. What timeout, if any, does the desklet use and can it be adjusted for testing purposes? I'd like to try a silly long timeout and see if it makes any difference.

@schorschii
Copy link
Contributor

I took a closer look at recent false positive notifications and they all report a ping time exceeding 1000 ms.

@zhurin OK, that's an indication. You can adjust the timeout in

['/bin/ping', this.host, '-c1', '-w2'], /*argv*/
for testing purposes. It's currently set to 2 seconds which is already quite long for a ping.

@zhurin
Copy link

zhurin commented Aug 14, 2024

Thanks for the quick reply. I agree that 2 seconds should be plenty, but at least it's something to take a look at. Since what I saw for each failed ping was a time of 1000 ± 20 ms, the current timeout shouldn't be the issue, but I'll try it anyway and see what happens.

Since this issue is sporadic, if the timeout change works, I'll probably keep it for a while to ensure that the resulting lack of false positives isn't just random. Stay tuned...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants