Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding WebDriver+Chrome server to the Docker Build #14

Closed
1 task done
Gill-Bates opened this issue Dec 22, 2023 · 9 comments
Closed
1 task done

Adding WebDriver+Chrome server to the Docker Build #14

Gill-Bates opened this issue Dec 22, 2023 · 9 comments
Labels
enhancement New feature or request no-issue-activity

Comments

@Gill-Bates
Copy link

Is this a new feature request?

  • I have searched the existing issues

Wanted change

The Chrome/Javascript method requires a network connection to a running WebDriver+Chrome server, set by the ENV var 'WEBDRIVER_URL'.

Reason for change

Using the Screenshot functionality

Proposed code change

No response

@Gill-Bates Gill-Bates added the enhancement New feature or request label Dec 22, 2023
Copy link

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@LinuxServer-CI
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@Nosen92
Copy link

Nosen92 commented Jan 24, 2024

Agreed. Many of changedetection's features have the playwright browser as a dependency. Without it changedetection can only detect rudimentary changes, and many advanced features like browser steps, screenshots and logins are unavailable.

@thespad
Copy link
Member

thespad commented Jan 24, 2024

Playwright won't provide muslc wheels and don't support source builds from pypi which makes life difficult.

Could you try with docker.io/thespad/playground:changedetection and see if the playwright element works correctly.

In terms of Chrome we're not going to bundle Chromium in the container as it would basically double the size, and the webdriver depends on it so it's not like we can just install that part of it. If you want to add it yourself you can use https://github.com/linuxserver/docker-mods/tree/universal-package-install to do so based on the available packages here: https://pkgs.alpinelinux.org/packages?name=chromium-chromedriver&branch=v3.19

@thespad
Copy link
Member

thespad commented Jan 24, 2024

Actually, I was wrong, it nearly triples the size of the image

changedetection                      chrome            4c88d381fec0   7 seconds ago    973MB
changedetection                      latest            2a7b3e8b8649   13 minutes ago   366MB

@Nosen92
Copy link

Nosen92 commented Jan 25, 2024

Disappointing that playwright doesn't build. That really clips the wings on changedetection. Thank you for the advice. I'll tinker with it when I find the time.

@thespad
Copy link
Member

thespad commented Jan 25, 2024

The image I posted has playwright built from source from their git repo. It's a pain but not unworkable if it enables the functionality.

@LinuxServer-CI
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link

This issue is locked due to inactivity

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request no-issue-activity
Projects
Archived in project
Development

No branches or pull requests

4 participants