Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Cannot set ldap.OPT_REFERRALS, 0 #49

Closed
1 task done
grrttedwards opened this issue May 24, 2023 · 3 comments · Fixed by #50
Closed
1 task done

[BUG] Cannot set ldap.OPT_REFERRALS, 0 #49

grrttedwards opened this issue May 24, 2023 · 3 comments · Fixed by #50

Comments

@grrttedwards
Copy link
Contributor

grrttedwards commented May 24, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When this fork was made, the code to disable referrals was commented out

Compare upstream:
https://github.com/nginxinc/nginx-ldap-auth/blob/c98eb555f5faba6b6efdddad4071afa56464d2c5/nginx-ldap-auth-daemon.py#L231-L233

With this project:
https://github.com/linuxserver/docker-ldap-auth/blob/26f790dee26fa4a1b16764bce562200384f912f1/root/app/nginx-ldap-auth-daemon.py#LL238C57-L238C57

The example config shows how to, and my use case requires this:
https://github.com/nginxinc/nginx-ldap-auth/blob/c98eb555f5faba6b6efdddad4071afa56464d2c5/nginx-ldap-auth.conf#L112-L115

Expected Behavior

Referrals cannot be disabled

@github-actions
Copy link

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@aptalca
Copy link
Member

aptalca commented May 24, 2023

Do you mind opening a PR with the upstream changes?

@grrttedwards
Copy link
Contributor Author

Done via #50

aptalca added a commit that referenced this issue Jun 20, 2023
Fix #49. Sync upstream changes to root/app/nginx-ldap-auth-daemon.py, and expose X-Ldap-DisableReferrals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants