Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Release docker image for Resilio Sync 3.0 #49

Closed
1 task done
Joly0 opened this issue Aug 12, 2024 · 13 comments
Closed
1 task done

[FEAT] Release docker image for Resilio Sync 3.0 #49

Joly0 opened this issue Aug 12, 2024 · 13 comments

Comments

@Joly0
Copy link

Joly0 commented Aug 12, 2024

Is this a new feature request?

  • I have searched the existing issues

Wanted change

Update the docker image to use resilio sync 3.0

Reason for change

Resilio sync 3.0 has been released, but the new versions are not covered by the curl request curl -sX GET https://linux-packages.resilio.com/resilio-sync/deb/dists/resilio-sync/non-free/binary-amd64/Packages so it isnt grabbed correctly. There still is a deb file to download and install it https://help.resilio.com/hc/en-us/articles/206178924-Installing-Sync-package-on-Linux

Proposed code change

No response

Copy link

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@Roxedus
Copy link
Member

Roxedus commented Aug 12, 2024

We need a repository, or some other endpoint to programmatically get new releases from. Getting the release number from html is unreliable

@Joly0
Copy link
Author

Joly0 commented Aug 12, 2024

As far as i know, there is none (yet)

@haroldfinch69
Copy link

I hate to be the bearer of bad news but they have depreciated support for docker .

Can the download endpoint be used? The files are hosted at: ttps://download-cdn.resilio.com/stable/linux/x64/0/resilio-sync_x64.tar.gz

@Schu-
Copy link

Schu- commented Aug 15, 2024

Sigh. This is some sad news......

@haroldfinch69
Copy link

I agree, however it has forced me to look beyond just the Linuxserver docker-compose file, and it's forced me to create my own dockerfile and image from scratch. It's been a good learning opportunity!

@Roxedus
Copy link
Member

Roxedus commented Aug 16, 2024

Can the download endpoint be used?

No, we need a programmatic way to get the version number without downloading it, before considering alternate sources.

@Joly0
Copy link
Author

Joly0 commented Aug 16, 2024

Can the download endpoint be used?

No, we need a programmatic way to get the version number without downloading it, before considering alternate sources.

I guess then this container wont receive any more updates as it seems like resilio wont update their usual sources for this

@aptalca
Copy link
Member

aptalca commented Aug 16, 2024

They still have the repo listed as an installation source. The repo has not been updated to host 3.0, but they didn't say that the repo is deprecated. Only the docker method is listed as deprecated here: https://help.resilio.com/hc/en-us/articles/206178924-Installing-Sync-package-on-Linux

@Joly0
Copy link
Author

Joly0 commented Aug 16, 2024

Hm, ok. But they havent updated it yet, which is kinda weird imo. But i also noticed, that the binhex docker has already been updated to 3.0. Maybe it might be worth to take a look how they do the check for new versions. Maybe they have found a good method which could be adapted to this one here?

@Roxedus
Copy link
Member

Roxedus commented Aug 16, 2024

Binhex' detection does not seem automated

@WizenThorne
Copy link

WizenThorne commented Aug 20, 2024

So long as syncing doesn't break between 2.8 and 3.0 I'm personally not in any rush to update, but it sounds like there are some transfer rate benefits in 3.0?

Also, the fact that binhex is on 3.0 is great news, as the Docker deprecation was worrisome at first.

Anyway, thank you to the Linuxserver team for all of your hard work!!! ❤️

@denkristoffer
Copy link

latest is pointing to a v3 release now so watch out if you haven't pinned your version yet 😄

@thespad thespad closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

8 participants