Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

favicon missing from basepage.html ? #163

Closed
1 task done
luckman212 opened this issue Nov 22, 2023 · 5 comments
Closed
1 task done

favicon missing from basepage.html ? #163

luckman212 opened this issue Nov 22, 2023 · 5 comments

Comments

@luckman212
Copy link

luckman212 commented Nov 22, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When I deploy this docker-smokeping image, the container does not contain the latest basepage.html, with a favicon.

This is a minor issue, but helps to quickly identify the site in bookmarks or open tabs, so is genuinely useful.

I have noticed this behavior for several months, and as of the latest release 2.8.2-r2-ls66

screenshot_LFcqtGbM

vs (where I hand-edited the file to add the base64 encoded favicon from this commit)

image

Steps To Reproduce

  1. deploy docker image
  2. visit page
  3. inspect icon...

Environment

- OS: Ubuntu 22.04.3
- Docker installed via snap

CPU architecture

x86-64

Docker creation

docker run -d \
--name smokeping \
-p 8080:80 \
-v /var/snap/docker/common/var-lib-docker/volumes/smokeping/config:/config \
-v /var/snap/docker/common/var-lib-docker/volumes/smokeping/data:/data \
-v /var/snap/docker/common/var-lib-docker/volumes/smokeping/cache:/var/cache/smokeping \
-e TZ='America/New_York' \
linuxserver/smokeping
Copy link

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@luckman212
Copy link
Author

Hello, is this issue being rejected? I saw the comment about it being invalid but I believe I have provided all the necessary info.

I updated to the 2.8.2-r2-ls70 tag but the issue remains.

@j0nnymoe
Copy link
Member

Smokeping haven't cut a release since August 2021 and that looks like it was added 11 months ago.

@LinuxServer-CI
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@LinuxServer-CI LinuxServer-CI closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
Copy link

This issue is locked due to inactivity

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

3 participants