Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] TCPPing Timeout does display 255ms instead of loss #164

Closed
1 task done
filou01 opened this issue Nov 29, 2023 · 4 comments · Fixed by #165
Closed
1 task done

[BUG] TCPPing Timeout does display 255ms instead of loss #164

filou01 opened this issue Nov 29, 2023 · 4 comments · Fixed by #165

Comments

@filou01
Copy link

filou01 commented Nov 29, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

in the current used tcpping version a loss is displayd as 255ms reply time.
I´ve found out that the combination of the elder shipped tcptraceroute version of busybox and the currently used tcpping V1.7 combination does not work.
The latest tcpping 2.5 also does not work, because this does not use tcptraceroute but uses traceroute what leads to problems.

The easiest solution i found out that works as expected is to use tcpping v1.8 instead of v1.7.
I´ve downloaded it inside the running container and tested it carefully
The source is here: https://github.com/deajan/tcpping/blob/original-1.8/tcpping

Please include it in the docker image instead of the currently included version 1.7

There was another bug report in the past with the same problem and without a solution - now i told you the solution.
#65

The path to the file that needs to be replaced is: https://github.com/linuxserver/docker-smokeping/blob/master/root/defaults/tcpping

regards, Christoh

Expected Behavior

No response

Steps To Reproduce

create a tcpping probe that times out and see the graph

Environment

- OS:
- How docker service was installed:

CPU architecture

x86-64

Docker creation

-

Container logs

-
@thespad
Copy link
Member

thespad commented Nov 29, 2023

I don't have a problem with adding the non-busybox traceroute to the container as an alternative.

@filou01
Copy link
Author

filou01 commented Nov 29, 2023 via email

@thespad thespad mentioned this issue Nov 29, 2023
1 task
@thespad
Copy link
Member

thespad commented Nov 29, 2023

Please can you test lspipepr/smokeping:2.8.2-r2-pkg-2558f655-dev-9d4899863a2bf2b32f523c2cb92cd7944003d9d6-pr-165

@filou01
Copy link
Author

filou01 commented Nov 30, 2023

Thank you... Tested successfully in our productive environment. Also the other probes are still working without any troubes.
From my point of view it could be merged into the master branch.

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants