Discount bandit #719
Open
Discount bandit #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[pull] master from linuxserver:master
[pull] master from linuxserver:master
[pull] master from linuxserver:master
Signed-off-by: Joseph Harry <findarato@gmail.com>
|
I do not think the error is with my pull. |
pagdot
suggested changes
Nov 26, 2024
Comment on lines
+2
to
+3
| # make sure that your <container_name> container is named <container_name> | ||
| # make sure that your dns has a cname set for <container_name> |
There was a problem hiding this comment.
Replace <container_name> with discountbandit
| set $upstream_proto http; | ||
| proxy_pass $upstream_proto://$upstream_app:$upstream_port; | ||
|
|
||
| # REMOVE THIS LINE BEFORE SUBMITTING: Additional proxy settings such as headers go below this line, leave the blank line above. |
There was a problem hiding this comment.
REMOVE THIS LINE BEFORE SUBMITTING
Comment on lines
+2
to
+3
| # make sure that your <container_name> container is named <container_name> | ||
| # make sure that <container_name> is set to work with the base url /<container_name>/ |
There was a problem hiding this comment.
Replace <container_name> with discountbandit
| set $upstream_proto http; | ||
| proxy_pass $upstream_proto://$upstream_app:$upstream_port; | ||
|
|
||
| # REMOVE THIS LINE BEFORE SUBMITTING: Additional proxy settings such as headers go below this line, leave the blank line above. |
There was a problem hiding this comment.
REMOVE THIS LINE BEFORE SUBMITTING
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for discount-bandit
Description
Benefits of this PR and context
How Has This Been Tested?
I am using this in my homelab right now.
Source / References