Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the way schema changes are revisioned. #111

Open
billgeo opened this issue Apr 23, 2018 · 4 comments
Open

Review the way schema changes are revisioned. #111

billgeo opened this issue Apr 23, 2018 · 4 comments

Comments

@billgeo
Copy link
Contributor

billgeo commented Apr 23, 2018

Dropping columns in revisioned data has caused some issues and is not best practice as we lose history. One idea is to not allow dropping columns for revisioned data. This would need to be decided with Property Rights who sometimes drop columns in Landonline and the BDE output.

See discussion at #106

@palmerj
Copy link
Contributor

palmerj commented Apr 23, 2018

The other ideas to to allow dropping columns are:

  1. On deleting a column that's the end of the versioned table. A new master table is required and then we version that. Drawback is we don't get the table history in one revision table.

  2. the column never actually gets dropped in the xx_revision table, it only marked as deleted from a given revision. This is what Koordiantes does. Drawback is this solution is more complex to implement and would involve a system table to record the schema at given revisions (maybe just a json definition). Under this solution the ver_get_xx_xx_diff and ver_get_xx_xx_revision functions would need to be updated to return the correct the columns and results (e.g if column is delete then all rows have changed). Also this solution might be a API breaking change as the function signatures the column names and types are hard coded and we might not what that anymore...

@imincik
Copy link
Contributor

imincik commented Apr 23, 2018

Definitely I prefer more second option.

@stale
Copy link

stale bot commented Oct 6, 2018

This issue has been automatically marked as stale as there has not been any activity for sometime. The issue will be closed in 14 days if no further activity.

@billgeo
Copy link
Contributor Author

billgeo commented Jul 12, 2022

Unlikely to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants