-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forbid having _revision_expired < _revision_added in _revision tables #78
Comments
Would be good to understand the performance hit of such a constraint |
It could be now a good occasion to test that performance hit, do you want a PR for this @imincik for testing as part of your current performance analisys ? |
PR #121 is ready for review/test |
This issue has been automatically marked as stale as there has not been any activity for sometime. The issue will be closed in 14 days if no further activity. |
Still relevant. |
The function
ver_get_$schema$_$table$_revision(p_revision integer)
(and possibly other) assume that_revision_expired
is always bigger or equal to_revision_added
failing which no revision would ever be considered to contain the corresponding record of a table.For this reason it would make sense to enforce such condition as an integrity constraint (a check).
Such database corruption was spotted and reported by downstream project here: https://github.com/linz/ds-dev-team/issues/46
The text was updated successfully, but these errors were encountered: