Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken wagtail blocks #50

Open
philli-m opened this issue Aug 18, 2022 · 10 comments
Open

Broken wagtail blocks #50

philli-m opened this issue Aug 18, 2022 · 10 comments

Comments

@philli-m
Copy link
Contributor

philli-m commented Aug 18, 2022

https://dev.liqd.net/en/blocks/
on landing page:

@fuzzylogic2000
Copy link
Contributor

@maxliqd Do you know if we use these blocks and if yes where and what for? We could remove the non-used ones if they are suuuperold and not used or fix them (like the paragraph one we should probably fix).

@fuzzylogic2000
Copy link
Contributor

fuzzylogic2000 commented Aug 26, 2022

@phillimorland What do you mean with the padding? Did you already fix it? (I cannot see what's wrong.)

Edited: you do mean it is wrong in the blocks, but fine on the academy page, right? :) I might fix the blocks thing, then!

@Rineee
Copy link
Contributor

Rineee commented Aug 26, 2022

@phillimorland What do you mean with the padding? Did you already fix it? (I cannot see what's wrong.)

Edited: you do mean it is wrong in the blocks, but fine on the academy page, right? :) I might fix the blocks thing, then!

No, I added that, but it looks fine now, so seems fixed!

@maxliqd
Copy link
Contributor

maxliqd commented Aug 29, 2022

I checked a couple of pages, could not finde those blocks anywhere, if that helps @fuzzylogic2000

Home page

  • html block

About

  • basic paragraph
  • Html block
  • Teaser list
  • Aligned image

Join us

  • Teaser list
  • Aligned image
  • Html block

Demokratie für alle (project)

  • Paragraph
  • Aligned image
  • Person import

@maxliqd maxliqd added this to the release 22 milestone Aug 29, 2022
@philli-m
Copy link
Contributor Author

@maxliqd sorry, I'm not sure above means? is that the blocks that are not used or the blocks that are used? and what would you like us to do with them?
also just a heads up, adding urls instead of pages names means we can find things much quicker, just for future :)

@maxliqd
Copy link
Contributor

maxliqd commented Aug 29, 2022

@phillimorland It is the ones we use on the pages

@maxliqd
Copy link
Contributor

maxliqd commented Aug 29, 2022

I couldn't find any of the broken blocks, apart from the paragraph block, but I also did not check all pages. Let me know if I should check a bit deeper.

@philli-m
Copy link
Contributor Author

@maxliqd thanks for clarification! If it is ok with you we will delete the image slider block as will be a lot of work to make it functional again.
The other unused blocks we can either neaten up in case you wish to use them in future or we can delete so them are not accidentally added and look bad. Which would you prefer?

@maxliqd
Copy link
Contributor

maxliqd commented Aug 29, 2022

@phillimorland I think I cannot answer this on my own, would need to ask someone from PR, probably Moritz, as I don't really know the initial purpose of the blocks. I will remove the issue from the milestone for now.

@maxliqd maxliqd removed this from the release 22 milestone Aug 29, 2022
@rittermo
Copy link

rittermo commented Sep 6, 2022

@maxliqd @phillimorland Thank you for looking into this! As far as I am aware we only need the paragraph block. The image slider, grey paragraph and quote block all came from the previous liqd.net design before 2017 and were probably carried over. They should not be in use anymore on the current design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants