Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Borrowers set their interest rate and Troves are ordered by interest rate #54

Closed
RickGriff opened this issue Jan 18, 2024 · 1 comment
Closed

Comments

@RickGriff
Copy link
Collaborator

RickGriff commented Jan 18, 2024

Borrowers set their interest rate and Troves are ordered by interest rate

Fullfills part of #40.

  • Each trove has a user-chosen interest rate property
  • Borrowers set this upon opening their Trove. We convert their chosen APR (yearly interest rate) to a per-time-unit rate (e.g. per-block or per-minute)
  • Borrowers can change their interest rate with changeInterestRate
  • The sorted list ordering key is this interest rate: whenever a borrower opens Trove or adjusts interest rate, their trove gets reinserted in the ordered list

TODO:

  • Composite function which adjusts both interest rate and coll and/or debt?
  • Actually calculate and apply the pending interest (add to Trove’s debt, mint BOLD) at Trove touches, batch updates, and SP touches (see issue X)
@bingen
Copy link
Collaborator

bingen commented Feb 21, 2024

Closed by #63

@bingen bingen closed this as completed Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants