Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operators passwords are not encryped and saved in plain text. WHY? #524

Open
momuskk opened this issue May 23, 2024 · 1 comment
Open

Operators passwords are not encryped and saved in plain text. WHY? #524

momuskk opened this issue May 23, 2024 · 1 comment
Labels

Comments

@momuskk
Copy link

momuskk commented May 23, 2024

Operators passwords are saved in DB in plain text.
Also operator password is returned to edit form without any encryption.

In configuration I can enable only to change type of input from text to password, but with devtool anyone can change it, also other operator can switch configuration to disable password masking.

Please add bcrypt to operators passwords. PHP has simply and elegant functions to do this: https://www.php.net/manual/en/function.password-hash.php and https://www.php.net/manual/en/function.password-verify.php

Only 2 lines but it is much safer.

@filippolauria
Copy link
Collaborator

Dear @momuskk , you made a reasonable point here.

We are aware of this issue and we had already planned to introduce some kind of password hashing in the future.
There are other concerns, tough. In fact what you suggest does not involves just "2 lines":

  • database field length should be updated
  • operator login procedure should be revised
  • operators add/edit should be revised
  • ...

Furthermore, these changes will inevitably affect all running instances of daloRADIUS around the world, so their migration should be somehow managed, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants