Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user import with Capital Letter for First and last Name does not work with 2.2 beta / 03 Jul 2024 works fine with 2.1 beta / 18 Apr 2024 #564

Open
kraman2681 opened this issue Sep 17, 2024 · 4 comments

Comments

@kraman2681
Copy link
Contributor

Describe the bug

we are testing Dalo radius 2.2 Beta version released on 3rd July 2024.
On our setup we have an external MYSQL speaking to Dalo.
the SQL is based on Azure MYSQL with version 8.0.
What we noticed is under user import,
if we provide the below, because the user first name starts with Capital S and Last name is capital P, the import fails.

S200002,P@sswOrd,S200002@acme.com,S200002,Plexinor.

this is the same for any user who's first name is Capital and last Name is also Capital.

we always get this error message

Sep 16 9:15:27 ACTIONS administrator Empty or invalid data provided on page: /mng-import-users.php

however if the same user is manually configured instead of user import, it works fine, in that case we can use Capital letter for First and Last name.

however for import user feature it only works when i change to it below
first name and last name for user needs to be lower case only then it will work

S200002,P@sswOrd,S200002@acme.com,s200002,plexinor.

To Reproduce
Steps to reproduce the behavior:

  1. go to import user on Dalo Radius version 2.2 Beta version released on 3rd July 2024
  2. just paste the following "S200002,P@sswOrd,S200002@acme.com,S200002,Plexinor"
  3. when you apply, you will get Invalid data or format error.
  4. See error

Expected behavior
we should be able to import users even if their first and last name starts with Capital letters.

Screenshots
Screenshot 2024-09-17 at 19 21 03

Screenshot 2024-09-17 at 19 21 03 Screenshot 2024-09-17 at 19 20 55

Desktop (please complete the following information):

  • OS: RHEL 8.
  • Your Browser: safari
  • daloRADIUS Version: 2.2 Beta version released on 3rd July 2024.
  • FreeRADIUS Version: 3
@kraman2681
Copy link
Contributor Author

it works fine on older Dalo version such as 2.1 beta / 18 Apr 2024
please refer to screenshot below
Screenshot 2024-09-17 at 19 27 17

Screenshot 2024-09-17 at 19 27 26 Screenshot 2024-09-17 at 19 27 33

@kraman2681
Copy link
Contributor Author

between these two versions I see Enable portal login is showing up on 2.2 Beta version released on 3rd July 2024. while this is not available on 2.1 beta / 18 Apr 2024

@kraman2681
Copy link
Contributor Author

This issue is now fixed, new master code has the fix, thanks Filippo Lauria for your support

@norrizuan1
Copy link

norrizuan1 commented Oct 3, 2024

Hi @kraman2681 ,
Can you try first name and last name with special characters e.g. (@), ('), (/). I tried and using the latest commit, the users with these special characters will be excluded.

There is an open issue regarding this #569.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants