Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large telnet option sequences are not properly processed #75

Open
ctoth opened this issue Feb 26, 2023 · 0 comments
Open

Large telnet option sequences are not properly processed #75

ctoth opened this issue Feb 26, 2023 · 0 comments

Comments

@ctoth
Copy link
Contributor

ctoth commented Feb 26, 2023

In src/network.cc line 464 if a telnet sequence does not end before the end of a single packet it is both ignored, and then further content is read as if it were a regular command, corrupting the next command.

Telnet option sequences can be longer than a single packet, and so this is not working correctly.

We may explore using libtelnet rather than implementing our own state machine to parse this properly, but that has its own downsides, as Libtelnet seems to want to fully take over the connection and we still want to be able to handle telnet commands in-MOO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant