Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform updates #1115

Merged
merged 13 commits into from
Aug 31, 2023
Merged

Platform updates #1115

merged 13 commits into from
Aug 31, 2023

Conversation

supernintendo
Copy link
Contributor

@supernintendo supernintendo commented Aug 22, 2023

Includes #1117.

@supernintendo supernintendo marked this pull request as ready for review August 29, 2023 14:55
Comment on lines 30 to 32
/// ## Attributes
/// - ``selection``
///
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may have been merged wrong, since the attributes section is duplicated here. The commit message of 8ed9dd3 matches bc73079 which is on main.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh weird. Any suggestions on how to fix? The only changes I need to include are on the Elixir side of things, but this includes #1117 which was merged into this branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be able to do an interactive rebase and drop 8ed9dd3. All it added was this doc comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carson-katri I was running into an issue with interactive rebase, so I just removed it in a subsequent commit.

/// />
/// <Image
/// name="dot_green"
/// modifiers={@native |> resizable() |> interpolation(interpolation: :medium)}
/// modifiers={resizable([]) |> interpolation(:medium)}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have an empty list being sent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, there might still be a bug with 0-arity modifiers in live_view_native but I thought we fixed this. I'll look into it and fix and/or update the docs in a subsequent PR.

@supernintendo supernintendo merged commit b2b7016 into main Aug 31, 2023
2 checks passed
@supernintendo supernintendo deleted the platform-updates branch August 31, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants