-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Platform updates #1115
Platform updates #1115
Conversation
ca63357
to
d48ad5e
Compare
/// ## Attributes | ||
/// - ``selection`` | ||
/// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh weird. Any suggestions on how to fix? The only changes I need to include are on the Elixir side of things, but this includes #1117 which was merged into this branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be able to do an interactive rebase and drop 8ed9dd3. All it added was this doc comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carson-katri I was running into an issue with interactive rebase, so I just removed it in a subsequent commit.
/// /> | ||
/// <Image | ||
/// name="dot_green" | ||
/// modifiers={@native |> resizable() |> interpolation(interpolation: :medium)} | ||
/// modifiers={resizable([]) |> interpolation(:medium)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have an empty list being sent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, there might still be a bug with 0-arity modifiers in live_view_native
but I thought we fixed this. I'll look into it and fix and/or update the docs in a subsequent PR.
a1741e3
to
3ea01f6
Compare
Includes #1117.