Reconnect when returning from background #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supernintendo
approved these changes
Aug 31, 2023
|
Am I correct in assuming that the socket reconnect will result in an app state reset? If so then we should explore solutions like this https://fly.io/phoenix-files/restore-liveview-state-on-startup/ |
|
Yes, that’s correct — assigns will be lost. It might be possible to keep sending the heartbeat message in a background task, but I’d have to experiment with that a bit more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, when left in the background for a few minutes, the app will lose connection. This PR adds a check that reconnects the socket when returning from the background.
It also fixes an issue with channel rejoins where diffs would be improperly applied, leading to a crash.