Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mlir][spirv] Update the spirv dialect scripts to accept the updated spirv json schema #110016

Open
kuhar opened this issue Sep 25, 2024 · 4 comments
Labels
help wanted Indicates that a maintainer wants help. Not [good first issue]. mlir:spirv

Comments

@kuhar
Copy link
Member

kuhar commented Sep 25, 2024

The SPIR-V dialect has scripts to define SPIR-V ops/enums/attributes based on the SPIR-V spec in the json format: https://github.com/llvm/llvm-project/tree/main/mlir/utils/spirv .

The json schema was recently updated: KhronosGroup/SPIRV-Headers#447. We should update the scripts to accept the new json format.

@kuhar
Copy link
Member Author

kuhar commented Sep 25, 2024

cc: @llvm-beanz

@llvmbot
Copy link
Collaborator

llvmbot commented Sep 25, 2024

@llvm/issue-subscribers-mlir-spirv

Author: Jakub Kuderski (kuhar)

The SPIR-V dialect has scripts to define SPIR-V ops/enums/attributes based on the SPIR-V spec in the json format: https://github.com/llvm/llvm-project/tree/main/mlir/utils/spirv .

The json schema was recently updated: KhronosGroup/SPIRV-Headers#447. We should update the scripts to accept the new json format.

@kuhar kuhar added the help wanted Indicates that a maintainer wants help. Not [good first issue]. label Sep 25, 2024
@cmarcelo
Copy link
Contributor

@kuhar posted #111778 to remove code that's not needed anymore since the grammar will have symbols de-duplicated.

As part of testing it out, ended up making also the following small fixes:

@kuhar
Copy link
Member Author

kuhar commented Oct 10, 2024

Awesome @cmarcelo, thanks for taking care of this. I left some comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Indicates that a maintainer wants help. Not [good first issue]. mlir:spirv
Projects
None yet
Development

No branches or pull requests

3 participants