backstage rule

package.json

@@ -11,6 +11,7 @@
     "type-check": "tsc  --noEmit"
   },
   "devDependencies": {
+    "@roadiehq/roadie-backstage-entity-validator": "^2.3.0",
     "@slack/client": "^4.2.2",
     "@types/jest": "^22.2.3",
     "@types/node": "^8.0.25",

rules/common/backstage.ts

@@ -0,0 +1,28 @@
+import { danger, fail } from "danger"
+import { validate } from "@roadiehq/roadie-backstage-entity-validator"
+
+const backstage = async () => {
+  const pr = danger.github.pr
+  const utils = danger.github.utils
+
+  const isOpen = pr.state === "open"
+
+  if (!isOpen) {
+    return
+  }
+
+  const filePath = "catalog-info.yaml"
+  const fileContent = await utils.fileContents(filePath, `${pr.head.user.login}/${pr.head.repo.name}`, pr.head.sha)
+
+  if (fileContent) {
+    try {
+      await validate(fileContent, true, "./schemas/backstage.annotations.json")
+    } catch (e) {
+      fail(`The 'catalog-info.yaml' file is not valid for Backstage. Error details:\n\n\`\`\`\n${e}\n\`\`\``)
+    }
+  } else {
+    fail(`The '${filePath}' file doesn't exist in the pull request.`)
+  }
+}
+
+export default backstage

rules/common/changelog.ts

@@ -20,7 +20,7 @@ const changelog = async () => {
     Object.prototype.hasOwnProperty.call(packageJson, "release")
 
   if (isOpen && hasChangelog && !hasSemanticRelease) {
-    const files = [...danger.git.modified_files, ...danger.git.created_files]
+    const files = [...(danger.git.modified_files || []), ...(danger.git.created_files || [])]
 
     const hasCodeChanges = files.find(file => !file.match(/(test|spec)/i))
     const hasChangelogChanges = files.find(file => changelogs_re.test(file))

rules/common/index.ts

@@ -3,6 +3,7 @@ import workInProgress from "./workInProgress"
 import mergeCommits from "./mergeCommits"
 import changelog from "./changelog"
 import testsUpdated from "./testsUpdated"
+import backstage from "./backstage"
 
 // Default run
 export default async () => {
@@ -11,4 +12,5 @@ export default async () => {
   mergeCommits()
   await changelog()
   testsUpdated()
+  await backstage()
 }

settings-peril.json

@@ -4,7 +4,7 @@
   },
   "rules": {
     "pull_request.opened": ["rules/common/approveReleasePR.ts", "rules/common/changelog.ts"],
-    "pull_request.synchronize": "rules/common/changelog.ts",
+    "pull_request.synchronize": ["rules/common/changelog.ts", "rules/common/backstage.ts"],
     "pull_request.closed": "rules/common/deleteMergedPRBranch.ts",
     "issue_comment.created": [
       "rules/common/markAsMergeOnGreen.ts",