Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add localsend-protocol-v3 #6

Closed
wants to merge 3 commits into from
Closed

add localsend-protocol-v3 #6

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 21, 2023

Hello everyone.

I made a pull request about this issue: login authentication ways for localsend

Possibly in version 3, it would be possible to have login extensions on the localsend protocol.

img:
image

I would like to contribute to this pull-request and I hope you all accept it.

@Tienisto
Copy link
Member

Tienisto commented Apr 4, 2023

Thanks for your contribution.

Generally, this can be added as v2.1 because it has no breaking changes for devices that understand v2.

Regarding public/private key:
There is an interesting issue localsend/localsend#357 that mentions two-side-ssl. In this case, devices can remember the SSL certificate and that's it. So we don't actually need to complicate the protocol and just use built-in two-way-SSL.

@ghost
Copy link

ghost commented Apr 6, 2023

Hi Tienisto.

Generally, this can be added as v2.1 because it has no breaking changes for devices that understand v2.

  • Maybe this protocol version would be "3" - because there are several concepts or ideas that are outside the scope of the first or second version of the protocol.
  • I think it's better to name it version 2.1. Because initially, the version 2 is used to compose some stuff.

Regarding public/private key:
There is an interesting issue localsend/localsend#357 that mentions two-side-ssl. In this case, devices can remember the SSL certificate and that's it.

So, If there is no public and private key, would it be possible with two-way-SSL to solve this problem above?

So we don't actually need to complicate the protocol and just use built-in two-way-SSL.

So, Is it possible to authenticate only with two-way-SSL one or more devices, and one or more files?

note: Another interesting use case for the public and private key would be interesting is when you need to send some shared link. Please, see this - too: share links Feature request

If you have time to answer my questions, I would be happy for your brief contact.

@ghost ghost mentioned this pull request Apr 7, 2023
@ghost ghost closed this by deleting the head repository Jan 1, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant