From 3bbfd64dba6c1003e5a6f88474c628542394903e Mon Sep 17 00:00:00 2001
From: Chris Fiege <cfi@pengutronix.de>
Date: Mon, 7 Aug 2023 11:37:22 +0200
Subject: [PATCH] client1 + client2: Fix `onsubmit` event handler to allow
 submitting

According to the documentation
(https://lona-web.org/1.x/api-reference/views.html#post ) it should be
possible to submit a `<form>` using `POST` to an interactive lona view.
Without this change this fails with a
`Uncaught ReferenceError: lona_window is not defined` in the browser.

This change fixes the missing reference and allows to use the `POST` method
to submit data to the view.

(Also add a test to make sure a POSTed `<form>` still works in the
future.)

Signed-off-by: Chris Fiege <cfi@pengutronix.de>
---
 lona/client/_lona/client/input-events.js   |  2 +
 lona/client2/_lona/client2/input-events.js |  2 +
 tests/test_0305_requests.py                | 60 ++++++++++++++++++++++
 3 files changed, 64 insertions(+)
 create mode 100644 tests/test_0305_requests.py

diff --git a/lona/client/_lona/client/input-events.js b/lona/client/_lona/client/input-events.js
index 25b95799..a088f833 100644
--- a/lona/client/_lona/client/input-events.js
+++ b/lona/client/_lona/client/input-events.js
@@ -202,6 +202,8 @@ export class LonaInputEventHandler {
     };
 
     _patch_onsubmit(node) {
+        var lona_window = this.lona_window;
+
         node.onsubmit = function(event) {
             event.preventDefault();
             event.stopPropagation();
diff --git a/lona/client2/_lona/client2/input-events.js b/lona/client2/_lona/client2/input-events.js
index c341b1ca..41174a13 100644
--- a/lona/client2/_lona/client2/input-events.js
+++ b/lona/client2/_lona/client2/input-events.js
@@ -202,6 +202,8 @@ export class LonaInputEventHandler {
     };
 
     _patch_onsubmit(node) {
+        var lona_window = this.lona_window;
+
         node.onsubmit = function(event) {
             event.preventDefault();
             event.stopPropagation();
diff --git a/tests/test_0305_requests.py b/tests/test_0305_requests.py
new file mode 100644
index 00000000..123974a0
--- /dev/null
+++ b/tests/test_0305_requests.py
@@ -0,0 +1,60 @@
+async def test_post_requests(lona_app_context):
+    """
+    This test checks if <form>-requests as GET and POST work as intended.
+    """
+
+    import json
+
+    from playwright.async_api import async_playwright
+
+    from lona.html import TextInput, Submit, HTML, Form, Div
+    from lona import View
+
+    def setup_app(app):
+
+        @app.route('/')
+        class Index(View):
+            def handle_request(self, request):
+                return HTML(
+                    Div(request.method, _id='method'),
+                    Div(json.dumps(request.POST), _id='post-data'),
+                    Form(
+                        TextInput(name='input-1'),
+                        Submit(),
+                        method='POST',
+                    ),
+                )
+
+    context = await lona_app_context(setup_app)
+
+    async def get_method(page):
+        element = page.locator('#method')
+
+        return (await element.inner_html())
+
+    async def get_post_data(page):
+        element = page.locator('#post-data')
+        json_string = await element.inner_html()
+
+        return json.loads(json_string)
+
+    async with async_playwright() as p:
+        browser = await p.chromium.launch()
+        browser_context = await browser.new_context()
+        page = await browser_context.new_page()
+
+        # GET request
+        await page.goto(context.make_url('/'))
+        await page.wait_for_url('/')
+
+        assert await get_method(page) == 'GET'
+        assert await get_post_data(page) == {}
+
+        # POST request
+        await page.locator('input[name=input-1]').fill('foo')
+        await page.click('input[type=submit]')
+
+        await page.wait_for_url('/')
+
+        assert await get_method(page) == 'POST'
+        assert await get_post_data(page) == {'input-1': 'foo'}