From 9254e2eb703708033e5ea332b215f82f286cfc66 Mon Sep 17 00:00:00 2001 From: Florian Scherf Date: Thu, 9 Feb 2023 18:38:42 +0100 Subject: [PATCH] views: fix feature flag settings.STOP_DAEMON_WHEN_VIEW_FINISHES This feature flag was added in 5fc9841891d4 ("settings: defaults: add feature flag for `LonaView.is_daemon`") but never worked, when set globally. When the view runtime checks if a view should be stopped, if daemonized, it uses `settings.STOP_DAEMON_WHEN_VIEW_FINISHES` and `View.STOP_DAEMON_WHEN_VIEW_FINISHES` as local override. Since `View.STOP_DAEMON_WHEN_VIEW_FINISHES` was set to `True` in the base class, this override won every time. This patch removes `View.STOP_DAEMON_WHEN_VIEW_FINISHES`, so it becomes an optional override, for `settings.STOP_DAEMON_WHEN_VIEW_FINISHES`. Signed-off-by: Florian Scherf --- lona/view.py | 1 - 1 file changed, 1 deletion(-) diff --git a/lona/view.py b/lona/view.py index 271713d2..ea70a42b 100644 --- a/lona/view.py +++ b/lona/view.py @@ -27,7 +27,6 @@ class View: STATIC_FILES: list[StaticFile] = [] - STOP_DAEMON_WHEN_VIEW_FINISHES = True # TODO: remove in 2.0 def __init__( self,