-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in i18n.dart when using Indonesian locale #63
Comments
That's an unfortunate bug, and will most probably cause backward-compatibility issues if we add a prefix or suffix to the class names. I guess we have to add special checks for |
@umutseven92 are you able to submit a pr (Kotlin) to fix this bug? |
@noordawod Sure, ill take a look as soon as a I am able. |
@noordawod So I did some digging and turns out this problem also occurred with the Icelandic locale (the country code is in, another reserved keyword). Issue here. It was fixed on 0.2, however since my Intellij version is 2019.1, I can only download version 0.0.6, which is very old. Long story short, I cannot test if the issue persists or not in the latest version. I will come back to this after Issue 53 is solved. |
I will release a recent version of the plugin for 2019.1 this week. Thanks for taking the time to check this, @umutseven92! |
@noordawod Some part of your build pipeline seems to be broken. There has not been an update ever since you wrote that comment. I am currently forced to build the plugin locally and set "ideaVersionPrefix=191" manually in the gradle.properties. |
@umutseven92 not entirely abandoned, mind you, but the maintainers occasionally need to attend to other important matters in life. In any case, the most recent plugin code is now pushed to JetBrains' repo -- it'll take few days for them to approve it. |
@umutseven92 I am also switching to VSCode and I found the extension you mentionned. |
Actually, "in" is deprecated for Indonesian Locale. Locale "id" is more recent for Indonesian. I found this on window.dart
|
After adding an .arb file in Indonesian locale (which has the country code in), the plugin adds:
to generated/i18n.dart file, which fails because in is a reserved keyword in the dart language. Since any changes to i18n.dart gets overridden immediately, right now it is impossible to use this plugin for Indonesian locale.
The text was updated successfully, but these errors were encountered: