Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border tile ownership incorrectly set to neutral on city destroyed #2448

Open
XHawk87 opened this issue Nov 26, 2024 · 1 comment
Open

Border tile ownership incorrectly set to neutral on city destroyed #2448

XHawk87 opened this issue Nov 26, 2024 · 1 comment
Labels
bug Something isn't working server This issue requires changes to the server

Comments

@XHawk87
Copy link
Contributor

XHawk87 commented Nov 26, 2024

Describe the bug
When a city is destroyed, tiles around it are incorrectly set to neutral tile ownership, even when another (older) city covers some or all of those tiles. Borders are correctly recalculated at TC, but not before players can take advantage of the situation.

When restrictinfra is set, this allows use of restricted infrastructure on tiles that should belong to an enemy, but are incorrectly set to neutral.

It also allows a player to found a city in what should be enemy territory but is not, allowing them to claim more border tiles than they should be able to.

To Reproduce
Steps to reproduce the behaviour:

  1. Build some heavily overlapping cities of at least 2 different nations.
  2. Attack and destroy one of the newer cities that overlap with a friendly older city.
  3. Notice that the border tile ownership is set to neutral in overlapping areas.
  4. Notice that roads can be used in these overlapping neutral tiles
  5. Notice that cities can be placed in these overlapping neutral tiles
  6. Notice that the border changes at TC

Expected behaviour
Tiles within range of neighbouring cities should remain under their ownership when a city is destroyed, such that no border changes are observed at TC.

@XHawk87 XHawk87 added bug Something isn't working Untriaged This issue or PR needs triaging labels Nov 26, 2024
@Corbeau-1
Copy link
Contributor

Borders are correctly recalculated at TC

Not entirely true. If the removed city is on the border, it may happen that at TC some of the neutralised tiles change hands, changing the old border.

@lmoureaux lmoureaux added server This issue requires changes to the server and removed Untriaged This issue or PR needs triaging labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working server This issue requires changes to the server
Projects
None yet
Development

No branches or pull requests

3 participants